Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test setup and reorg handling tests #95

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Test setup and reorg handling tests #95

merged 1 commit into from
Oct 10, 2024

Conversation

iuwqyir
Copy link
Collaborator

@iuwqyir iuwqyir commented Oct 8, 2024 •
edited
Loading

  • Creates a test setup using testify and mockery.
  • Adds CI test workflow
  • Production build now must include "production" tag to not include mocks
  • Adds first tests to the service covering reorg handling

This was referenced Oct 8, 2024
Merged
Merged
Merged
@iuwqyir Graphite App
Copy link
Collaborator Author

iuwqyir commented Oct 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iuwqyir and the rest of your teammates on Graphite Graphite

This was referenced Oct 8, 2024
Merged
Merged
@iuwqyir iuwqyir changed the title test setup and reorg tests Test setup and reorg handling tests Oct 8, 2024
@iuwqyir iuwqyir requested a review from AmineAfia October 8, 2024 16:43
@iuwqyir iuwqyir marked this pull request as ready for review October 8, 2024 16:43
@iuwqyir iuwqyir force-pushed the 10-08-test_setup_and_reorg_tests branch from d1f0179 to d759e6d Compare October 8, 2024 17:56
@iuwqyir iuwqyir force-pushed the 10-08-create_interface_for_rpc branch from 147e153 to df18b17 Compare October 8, 2024 23:32
@iuwqyir iuwqyir force-pushed the 10-08-test_setup_and_reorg_tests branch 2 times, most recently from 7ade93f to af623db Compare October 8, 2024 23:50
@iuwqyir iuwqyir force-pushed the 10-08-create_interface_for_rpc branch from df18b17 to 91f74a5 Compare October 10, 2024 12:49
@iuwqyir iuwqyir force-pushed the 10-08-test_setup_and_reorg_tests branch from af623db to 36375ce Compare October 10, 2024 12:49
catalyst17
catalyst17 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@catalyst17 catalyst17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg!

@iuwqyir iuwqyir changed the base branch from 10-08-create_interface_for_rpc to graphite-base/95 October 10, 2024 14:11
@iuwqyir iuwqyir force-pushed the 10-08-test_setup_and_reorg_tests branch from 36375ce to 928529e Compare October 10, 2024 14:13
@iuwqyir iuwqyir changed the base branch from graphite-base/95 to main October 10, 2024 14:14
@iuwqyir iuwqyir force-pushed the 10-08-test_setup_and_reorg_tests branch from 928529e to 4d2bc5b Compare October 10, 2024 14:14
@iuwqyir iuwqyir merged commit df13321 into main Oct 10, 2024
5 checks passed
@iuwqyir Graphite App
Copy link
Collaborator Author

iuwqyir commented Oct 10, 2024

Merge activity

  • Oct 10, 10:15 AM EDT: A user merged this pull request with Graphite.

@iuwqyir iuwqyir deleted the 10-08-test_setup_and_reorg_tests branch October 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalyst17 catalyst17 catalyst17 approved these changes

@AmineAfia AmineAfia Awaiting requested review from AmineAfia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuwqyir @catalyst17